Fix add-on install when add-on is incompatible.#14997
Merged
Merged
Conversation
LeonarddeR
approved these changes
Jun 10, 2023
seanbudd
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14994
Summary of the issue:
NVDA would be unable to install some add-ons via Windows Explorer or the install addon from external source button.
Description of user facing changes
The incompatible dialog now works correctly instead of playing an the NVDA error sound.
Description of development approach
The _addonStoreGui.controls.messageDialogs._shouldInstallWhenAddonTooOldDialog was being imported incorrectly which was causing the ModuleNotFoundError.
Testing strategy:
Tried installing an addon from file explorer and from the install from external source button in the addon store.
Known issues with pull request:
None.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: