Add-on store: fix download pending install status loss#14992
Merged
Conversation
seanbudd
commented
Jun 9, 2023
Member
Is this change absolutely necessary to fix the download status issue? This seems to be a secondary change yet takes up the vast majority of the pr. Is it possible to split this into a separate pr if this is not necessary for the main issue? |
aa64481 to
a9c8cf8
Compare
michaelDCurran
approved these changes
Jun 19, 2023
…gInstallStatusLoss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Based on #15021
Fixes #14978
Summary of the issue:
Downloading and installing an add-on follows these steps:
addonStore/_dl/addonId.downloadaddonStore/_dl/addonId-1.23.nvda-addoni. if you change tab here, the add-on state can be lost
addons/addonId.pendingInstalladdons/addonId.pendingInstallis installed toaddons/addonIdWhen changing tabs before exiting the add-on store, the state "download pending install" is lost.
Description of user facing changes
When changing tabs before exiting the add-on store, the state "download pending install" is no longer lost.
Description of development approach
The pending install state check was updated for the add-on store add-on model to include checks for download state.
Add-ons that are downloaded pending install should now be treated as if they are pending install.
The add-on state determiner now returns the correct state for add-ons which are downloaded but yet to start the install process.
Testing strategy:
Test STR described in issue
Known issues with pull request:
N/A
Change log entries:
N/A
Code Review Checklist: