Skip to content

Moved the new Add-on Store subchapter to its own chapter in the User Guide#14971

Merged
seanbudd merged 8 commits into
nvaccess:masterfrom
XLTechie:moveStoreChapter
Jun 7, 2023
Merged

Moved the new Add-on Store subchapter to its own chapter in the User Guide#14971
seanbudd merged 8 commits into
nvaccess:masterfrom
XLTechie:moveStoreChapter

Conversation

@XLTechie

@XLTechie XLTechie commented Jun 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Link to issue number:

#14912 (comment)

Summary of the issue:

The Add-on Store subchapter was long enough to warrant a standalone chapter.

Description of user facing changes

  • Moved the store subchapter of "Extra Tools", to its own chapter before "Extra Tools".
  • Consequently, reduced all headings by one numbering level.
  • Renamed the new chapter from "Add-on Store", to "Add-ons and the Add-on Store".
  • Added a stub under the tools menu "Add-on store" description in the "Extra Tools" chapter, pointing to the new chapter.
  • Wrote a new introductory section, placing the description of add-ons first, and description of store second. Mostly based on what was there before, but more focused on the add-ons than the store at first.
  • Includes proposed rewording of the non-free add-ons sentences. N.b. this was done as its own commit, so can be reverted if @seanbudd would prefer the original wording we worked out in Proposed revisions to add-on store user guide subchapter #14966.

Description of development approach

Text editing to effect the above.

Testing strategy:

The Appveyor generated guide appears to render as intended.

Known issues with pull request:

Change log entries:

@XLTechie XLTechie marked this pull request as ready for review June 6, 2023 09:18
@XLTechie XLTechie requested a review from a team as a code owner June 6, 2023 09:18
@XLTechie XLTechie requested a review from Qchristensen June 6, 2023 09:18
seanbudd
seanbudd reviewed Jun 7, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XLTechie, just a couple minor suggestions

Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
@XLTechie @seanbudd
Apply suggestions from code review
931bd06 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@XLTechie

XLTechie commented Jun 7, 2023 via email

Copy link
Copy Markdown
Collaborator Author

Qchristensen
Qchristensen approved these changes Jun 7, 2023
View reviewed changes

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change, it's a bigger block of text than the other extra tools.

@seanbudd seanbudd merged commit 444b568 into nvaccess:master Jun 7, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@Qchristensen Qchristensen Qchristensen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

4 participants

@XLTechie @seanbudd @Qchristensen @nvaccessAuto