Skip to content

Add-on store: fix support for starting NVDA with add-ons disabled#14967

Merged
seanbudd merged 2 commits into
masterfrom
addonStoreDisabledAddons
Jun 7, 2023
Merged

Add-on store: fix support for starting NVDA with add-ons disabled#14967
seanbudd merged 2 commits into
masterfrom
addonStoreDisabledAddons

Conversation

@seanbudd

@seanbudd seanbudd commented Jun 6, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Raised in #14912 (comment)

Summary of the issue:

When starting NVDA with add-ons disabled (e.g. through --disable-addons), enabled add-ons are not displayed in the add-on store.

Description of user facing changes

When NVDA starts with add-ons disabled:

  • Add-on store now displays enabled add-ons
  • A banner is shown to warn the user that add-ons are disabled

Description of development approach

Add a new state to differentiate between enabled and running, and enabled while not running.

Testing strategy:

Manual testing

  1. Start NVDA with add-ons disabled
  2. Ensure enabled add-ons are shown in the list.

Known issues with pull request:

None

Change log entries:

N/A unreleased regression

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner June 6, 2023 02:25
@seanbudd seanbudd requested a review from michaelDCurran June 6, 2023 02:25
@seanbudd seanbudd changed the title Add-on store: add support for --disable-addons Add-on store: fix support for starting NVDA with add-ons disabled Jun 6, 2023
Comment thread source/_addonStore/models/status.py
@seanbudd seanbudd requested a review from michaelDCurran June 7, 2023 00:25
@seanbudd seanbudd merged commit 68a5a05 into master Jun 7, 2023
@seanbudd seanbudd deleted the addonStoreDisabledAddons branch June 7, 2023 04:27
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants