Toggle braille show selection indicator also with input gesture#14959
Merged
seanbudd merged 5 commits intoJun 9, 2023
Conversation
seanbudd
reviewed
Jun 5, 2023
Comment on lines
+3309
to
+3310
| msg = _("Braille show selection") | ||
| msg += f" {self._featureFlagDefaultBehaviorDisplayString(displayString)}" |
Member
There was a problem hiding this comment.
This should be a single string so translators can re-arrange the parts.
Suggested change
| msg = _("Braille show selection") | |
| msg += f" {self._featureFlagDefaultBehaviorDisplayString(displayString)}" | |
| msg = _("Braille show selection default (%s)") % featureFlag.behaviorOfDefault.displayString |
Collaborator
There was a problem hiding this comment.
Why not a format string?
Suggested change
| msg = _("Braille show selection") | |
| msg += f" {self._featureFlagDefaultBehaviorDisplayString(displayString)}" | |
| msg = _("Braille show selection default ({})").format(featureFlag.behaviorOfDefault.displayString) |
Contributor
Author
There was a problem hiding this comment.
I think that would be also possible. But why not "f style" with one msg assignment (asking this just for curiosity).
Member
There was a problem hiding this comment.
gettext (the translation library) doesn't support f strings
CyrilleB79
reviewed
Jun 5, 2023
See test results for failed build of commit 60cfb82c35 |
See test results for failed build of commit 57c64c59cb |
Collaborator
|
@burmancomp It appears that you may have pushed a bunch of unrelated commits
from the master branch.
Your last push had 15 commits, your total commits is now 18 I believe, and most
of them are other people's work that was already merged.
At least, that's what it looked like from the GitHub notification email, and on
the commits tab of your PR.
|
08f726a to
c45a01b
Compare
Contributor
Author
This just shows that my understanding how different git commands work is very limited. My solution to commit problem is not elegant one but hopefully it works at least this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14948
Summary of the issue:
Selection is indicated with dots 7 and 8 which may cause difficulties for reading.
Description of user facing changes
There is feature flag setting "Show selection" in Braille category which default behavior is Enabled. There is also possibility to use input gesture to cycle setting.
Description of development approach
Feature flag (BoolFlag) showSelection which default behavior is Enabled.
Testing strategy:
Tested with input gesture and from settings dialog.
Known issues with pull request:
Change log entries:
New features
Possibility to toggle braille show selection indicator from braille settings and with input gesture.
Changes
Bug fixes
For Developers
Code Review Checklist: