Rewrote the user guide section about the settings dialog#14937
Merged
Conversation
* Reworded the initial paragraph to be more clear about categories and settings.
* Clarified a sentense about what shortcut keys for categories do.
* Made the note about adding shortcut keys for categories more clear.
- As it was written previously, it implied that adding shortcut keys might be the ONLY way to access those categories.
Qchristensen
requested changes
May 31, 2023
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Just one small suggestion (Change "a list with several configuration categories", to "a list of configuration categories" - since there are more than "several" now. Otherwise, all good.
…eral" from number of categories. Co-authored-by: Quentin Christensen <quentin@nvaccess.org> Co-authored-by: Sean Budd <seanbudd123@gmail.com>
seanbudd
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14927
Summary of the issue:
The issue asked that Ctrl+Tab and Shift+Ctrl+Tab be listed in the user guide section regarding the settings dialog, since many users don't know they can use those to move between categories.
Description of user facing changes
While editing the section, I found some awkward and seemingly redundant wording, and some unclear portions.
Description of development approach
I tried to imagine myself in the position of a user who didn't know much about manipulating settings or their dialogs; and rewrote a bit from that prospective.
Testing strategy:
The test will be whether @Qchristensen still talks to me after reading this.
Known issues with pull request:
Change log entries:
Changes
Clarified the user guide section describing the settings dialog.
Code Review Checklist:
There is no code.