Braille show messages input gesture#14898
Merged
seanbudd merged 11 commits intoJun 2, 2023
Merged
Conversation
CyrilleB79
reviewed
May 3, 2023
CyrilleB79
left a comment
Contributor
There was a problem hiding this comment.
@burmancomp, thanks.
I have not tested but the code seems correct.
I have juste some small change proposals below:
See test results for failed build of commit ac4a950d72 |
Qchristensen
approved these changes
May 8, 2023
Qchristensen
left a comment
Member
There was a problem hiding this comment.
User Guide (and the noted spelling correction) look good, thanks!
seanbudd
reviewed
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14864
Summary of the issue:
There are input gestures for example for cycle braille cursor shape, tether braille to and toggle show braille cursor but not for cycling braille show messages.
Description of user facing changes
New input gesture "Cycle through the braille show messages modes" in braille category.
Description of development approach
New script script_braille_cycleShowMessages in globalCommands.py.
Testing strategy:
Added buttons and tested with Input help mode on/off.
Known issues with pull request:
Change log entries:
New features
New input gesture "Cycle through the braille show messages modes" in braille category.
Changes
Bug fixes
For Developers
New script script_braille_cycleShowMessages in globalCommands.py.
Code Review Checklist: