Comment clarification/typo fixes about extensionPoints, across six files#14811
Merged
Conversation
added 6 commits
April 8, 2023 07:22
See test results for failed build of commit 4eab7d5021 |
seanbudd
approved these changes
Apr 11, 2023
seanbudd
left a comment
Member
There was a problem hiding this comment.
Approved, pending the lint fix
Collaborator
Author
|
@seanbudd Linted, GTG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
While working on #14810, I found several places where comments about the core extensionPoints could be made clearer, or had typos/capitalization errors/questionable grammar.
Description of user facing changes
None.
Description of development approach
I fixed them as I went along, and scooped them all into their own branch. Here is the result.
I changed no code in this, and nothing structural has been altered. That is, where
#:style comments were used in some places, and docstring style comments in others, I left them that way. I'm not actually sure what we prefer now. I wasn't trying to lint anything, just fix language.Testing strategy:
Letting Appveyor build this branch in the PR, and see if any lint errors pop out. That's about all I would expect to find.
Known issues with pull request:
None, unless the mixed comment style is an issue. But I didn't do that.
Change log entries:
None needed.
Code Review Checklist: