Skip to content

when searching for text, "not found" message style changed from ERROR to INFORMATION#14807

Merged
seanbudd merged 6 commits into
nvaccess:masterfrom
tseykovets:style_of_text_not_found_message
Jun 13, 2023
Merged

when searching for text, "not found" message style changed from ERROR to INFORMATION#14807
seanbudd merged 6 commits into
nvaccess:masterfrom
tseykovets:style_of_text_not_found_message

Conversation

@tseykovets

@tseykovets tseykovets commented Apr 7, 2023 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

When the Searching for text function does not find the text, NVDA shows a MessageBox.
Now the style of this MessageBox is ERROR. This pull request changes the style of this MessageBox to INFORMATION.
This message is literally not an error. This is information.

This change is proposed with the following considerations in mind:

  • Messages with the ERROR style have a recognizable appearance and are accompanied by a system error sound. For users, such messages carry negative associations and cause unpleasant emotions. It seems that there is no need to scare users with an ERROR style message in cases of text not found, because this situation is not comparable to situations of real errors in the system.
  • Other Windows applications do not use ERROR style messages in similar situations. For example, the standard Notepad application shows information about unfound text using messages in the INFORMATION style, and not ERROR. That is, this pull request brings NVDA closer to the unified Windows interface language.

Description of user facing changes

Message is displayed as information not error

Description of development approach

Changed message style, lint, add translator comments

Testing strategy:

Test searching text

Known issues with pull request:

None

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@tseykovets tseykovets requested a review from a team as a code owner April 7, 2023 17:01
@tseykovets tseykovets requested a review from seanbudd April 7, 2023 17:01
@AppVeyorBot

AppVeyorBot commented Apr 7, 2023

Copy link
Copy Markdown

See test results for failed build of commit 30e8e09a11

@seanbudd

seanbudd commented Apr 10, 2023

Copy link
Copy Markdown
Member

Please fill out the PR template

@seanbudd seanbudd closed this Apr 10, 2023
seanbudd
seanbudd reviewed Apr 10, 2023
View reviewed changes
Comment thread source/cursorManager.py Outdated
@seanbudd seanbudd reopened this Apr 10, 2023
@AppVeyorBot

AppVeyorBot commented Apr 10, 2023

Copy link
Copy Markdown

See test results for failed build of commit 6d32aba8e5

@seanbudd

seanbudd commented Apr 10, 2023

Copy link
Copy Markdown
Member

Marking this as draft until the template has been completed. Please let us know when you have linted your code and filled out the template

@seanbudd seanbudd marked this pull request as draft April 10, 2023 23:59
seanbudd
seanbudd reviewed Jun 13, 2023
View reviewed changes
Comment thread source/cursorManager.py
@seanbudd seanbudd marked this pull request as ready for review June 13, 2023 04:46
@seanbudd seanbudd changed the title Style of the Text not found message for the Searching for text function changed from ERROR to INFORMATION when searching for text, "not found" message style changed from ERROR to INFORMATION Jun 13, 2023
seanbudd
seanbudd reviewed Jun 13, 2023
View reviewed changes
Comment thread source/cursorManager.py Outdated
@AppVeyorBot

AppVeyorBot commented Jun 13, 2023

Copy link
Copy Markdown
  • FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
  • PASS: Unit tests.
  • PASS: Lint check.
  • FAIL: System tests (tags: installer NVDA). See test results for more information.
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/e18m0myatg7r46aj/artifacts/output/nvda_snapshot_pr14807-28418,6979a5cb.exe
  • CI timing (mins):
    INIT 0.0,
    INSTALL_START 1.0,
    INSTALL_END 0.9,
    BUILD_START 0.0,
    BUILD_END 24.1,
    TESTSETUP_START 0.0,
    TESTSETUP_END 0.3,
    TEST_START 0.0,
    TEST_END 18.9,
    FINISH_END 0.2

See test results for failed build of commit 6979a5cbd5

@seanbudd seanbudd merged commit 00f411c into nvaccess:master Jun 13, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 13, 2023
@seanbudd seanbudd mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

4 participants

@tseykovets @AppVeyorBot @seanbudd @nvaccessAuto