Fix message hooking regression#14789
Conversation
|
I tested the latest build and #14784 is still reproducible. |
|
Is this ime easily testable for people who do not understand Chinese? |
|
Just need to install Sogou Pinyin input method, if the steps in #14784 are not easy to understand, please let me know, I am more than willing to provide further explanation. |
|
Hi, I tested the latest build and #14784 is still reproducible. |
|
I hadn't thought about that, I have a vm myself, so that'll work. |
|
@cary-rowen The build that's currently being produced should fix your issue. Could you also confirm that #13335 is still no longer reproducible? |
|
Yes, I tested, and the latest build fixes #14784 , thanks. |
|
Thanks @cary-rowen. How about #13335? |
|
Hi @LeonarddeR #13335 can also be covered by this PR, very nice. Thanks |
|
In that case, it's ready. |
|
@seanbudd This is ready. |
Link to issue number:
Follow up of #14759
Fixes #14784
Partially reverts 9b97de0
Summary of the issue:
At least one custom IME is reported to no longer work in editable controls within NVDA.
Description of user facing changes
Fix the regression
Description of development approach
We no longer use the background thread to handle cancellable messages, as it seems using the background thread causes IME messages to be discareded. This means a partial revert of 9b97de0. In fact, this pr removes the background thread but keeps the event based approach to cancel calls from NVDA's watchdog.
Testing strategy:
Known issues with pull request:
None known
Change log entries:
Add this pr and issue #14784 to the changelog entry for #14759
Code Review Checklist: