Add more warnings for when an action is blocked by a modal dialog#14782
Merged
Conversation
See test results for failed build of commit b41e08c39f |
michaelDCurran
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #14768
Summary of the issue:
NVDA menu and NVDA settings dialogs cannot be accessed when modal message dialogs are displayed.
When using gestures to open the NVDA menu and settings dialogs, users should be warned their action cannot be completed when a modal dialog is open.
Description of user facing changes
Added warning message to opening GUI windows/menus, when a modal dialog is open
Description of development approach
Added warning message to opening GUI windows/menus, when a modal dialog is open
Testing strategy:
Tested opening menus and settings dialogs when about dialog is open
Known issues with pull request:
Change log entries:
Not worthwhile
Code Review Checklist: