appModules/explorer: announce tab switches in Windows 11 2022 Update (22H2)#14770
Merged
Merged
Conversation
…(22H2). Re nvaccess#14388. Later revisions of Windows 11 2022 Update (22H2) introduces tabs to File Explorer, allowing users to press Control+Tab and Control+Shift+Tab to switch betwen tabs. Just like Notepad for Windows 11, UIA element selected event is fired when tab switching happens. Unlike Notepad implementation, speech will not be canceled (cut off) because doing so prevents announcement of list view items.
See test results for failed build of commit 4f6c04f77a |
See test results for failed build of commit eb60e279c5 |
seanbudd
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #14388
Summary of the issue:
Later revisions of Windows 11 22H2 (2022 Update) introduced tabbed File Explorer. At the moment NVDA does not announce tab names when switching to different tabs.
Description of user facing changes
NVDA will announce the name of the tab being switched to in Windows 11 2022 Update File Explorer.
Description of development approach
Similar to tabbed Notepad (#14588), use UIA element selected event handler to announce tab names. Unlike Notepad, speech should not be cut off to let NVDA announce focused item when File Explorer opens.
Testing strategy:
Manual testing (prerequisites: Windows 11 22H2 build 22621.675 and later): open File Explorer, press Control+T to open a new tab, press Control+Tab and Control+Shift+Tab to switch tabs, press Control+W to close tabs.
Known issues with pull request:
None
Change log entries:
Similar wording as Notepad 11 tab switching announcement but also adding File Explorer in Windows 11 2022 Update to it.
Code Review Checklist: