• PASS: Translation comments check.
• FAIL: Unit tests. See test results for more information.
• PASS: Lint check.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/xd2ykf1y0tkds471/artifacts/output/nvda_snapshot_pr14765-27960,8219280e.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 23.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 21.5,
  FINISH_END 0.1

See test results for failed build of commit 8219280edb

Hello

I have not revisited all the tickets on this topic. However, it seems that there are actually two requests from users that are handled together:

1. Is the battery charging? Yes/No; and as an addition, what is the charge level?
2. Is the charger plugged in?

For sighted people the first question is answered by the icon in the system tray.

Regarding the second question, I think that there is no visual indicator in Windows UI for sighted people. However blind people have expressed several times the need to know if the wire was plugged in (and correctly) or not.

I think that the issue should be handled more globally than this PR, if possible, and provide the 3 following information upon NVDA+B:

• x%, charger disconnected
• x%, charging battery (and obviously charger connected)
• x%, charger connected, battery fully charged

This would allow to make modifications back and forth between "charging battery" / "AC connected"

@CyrilleB79 I agree with you in general. See my comments at the end of the linked ticket about what is going on and why. What you request is possible, and can be done, but it will require a full rewrite of our battery module. I may work on that in the future, if nobody else gets to it first. But for now, I think what Sean has done is a quick solution that solves the immediate problem. We have a saying in the U.S.: don't let the perfect get in the way of the good. The perfect is what you ask. The good is what this does. Perhaps the immediate good can happen, while the perfect is figured out down the road?

Yes this makes sense. This PR is already an improvement and I support it to be merged (including the change requested by Mick).

Then for something more elaborated as described in my previous comment, a new ticket should be opened or, more likely, an old ticket that was recently closed could be reopened (Cc @Adriani90)

@CyrilleB79 the issue referenced in this PR is still open and covers your suggestions. The one I've closed is an old one which had less details so I closed it in favor of the new one.
I think this PR should say solves partially #14726 but does not fix it completely so that the issue remains open.

• PASS: Translation comments check.
• FAIL: Unit tests. See test results for more information.
• PASS: Lint check.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/whpp896x7o3rt4r5/artifacts/output/nvda_snapshot_pr14765-28013,ba822281.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.9,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 21.3,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 21.2,
  FINISH_END 0.2

See test results for failed build of commit ba822281b0