Skip to content

PR template: indicate when PR state need to be set to 'Ready'#14758

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
CyrilleB79:prTemplate
Mar 30, 2023
Merged

PR template: indicate when PR state need to be set to 'Ready'#14758
seanbudd merged 2 commits into
nvaccess:masterfrom
CyrilleB79:prTemplate

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

See #14610 (comment),

Summary of the issue:

Sometimes, people open PRs as a draft as required but do not seem to know that they need to transition it to "Ready for review" so that someone at NVAccess look at it.

In the PR template we can read:

Please initially open PRs as a draft. See https://github.com/nvaccess/nvda/wiki/Contributing

But nothing on when it should be set "Ready for review".

Description of user facing changes

See modified file.

Description of development approach

Updated the PR template.

Testing strategy:

  • Copy the .md in GitHub's comment area and previsualize it to check that the md syntax is correct, i.e. the modified text does not appear since it is in a comment tag.
  • Check when merged.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 29, 2023 14:04
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 29, 2023 14:04
@CyrilleB79 CyrilleB79 requested a review from seanbudd March 29, 2023 14:04
@ABuffEr

ABuffEr commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Thanks Cyrille. I was confused also from the code commenting/suggestion process, not understanding whether declare as draft again or not after changes.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@seanbudd seanbudd merged commit 753e2c7 into nvaccess:master Mar 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Mar 30, 2023
@CyrilleB79 CyrilleB79 deleted the prTemplate branch March 31, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants