PR template: indicate when PR state need to be set to 'Ready'#14758
Merged
Conversation
Contributor
|
Thanks Cyrille. I was confused also from the code commenting/suggestion process, not understanding whether declare as draft again or not after changes. |
seanbudd
reviewed
Mar 30, 2023
seanbudd
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
See #14610 (comment),
Summary of the issue:
Sometimes, people open PRs as a draft as required but do not seem to know that they need to transition it to "Ready for review" so that someone at NVAccess look at it.
In the PR template we can read:
But nothing on when it should be set "Ready for review".
Description of user facing changes
See modified file.
Description of development approach
Updated the PR template.
Testing strategy:
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: