Made two messages translatable.#14751
Merged
Merged
Conversation
seanbudd
approved these changes
Mar 28, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Reported on the translator's mailing list in this thread.
Summary of the issue:
PR #13798 introduced paragraph navigation in documents. Unfortunately two message added by this PR are not translatable: "No next/previous paragraph" since the gettext (_) function call has been forgotten; the translators comments are already there though.
Description of user facing changes
The message will be translatable
Description of development approach
Just added the call to the gettext function (_).
Testing strategy:
Manual:
Generate a .pot, merge to .po in French, translate it and use it with the feature.
Known issues with pull request:
While at it, I have searched for other occurrences of
ui.messagecalled with untranslated content. InNVDAObjects/IAccessible/winword.py, in the scriptscript_reportCurrentHeaders, I have found:ui.message("Row %s, column %s"%(rowText or "empty",columnText or "empty"))I have not fixed this as this script is a half buggy, half debug and undocumented script (see #11465 for details).
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist:
Cc @rob-aph