Conversation
From translation svn revision: 72435 Authors: Jani Kinnunen <janikinnunen340@gmail.com> Isak Sand <isak.sand@gmail.com> Stats: 3 3 source/locale/fi/characterDescriptions.dic 1 file changed, 3 insertions(+), 3 deletions(-)
From translation svn revision: 72435 Authors: Simone Dal Maso <simone.dalmaso@gmail.com> Alberto Buffolino <a.buffolino@gmail.com> Stats: 1 1 user_docs/it/changes.t2t 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 72435 Authors: Grzegorz Zlotowicz <grzezlo@wp.pl> Patryk Faliszewski <patric3031@wp.pl> Zvonimir Stanecic <9a5dsz@gozaltech.org> Dorota Krac <dorkakrac@yandex.com> Piotr Rakowski <kontakt@piotrrakowski.net> Hubert Meyer <hubmeyer1989@gmail.com> Arkadiusz Swietnicki <nuno69a@gmail.com> Stats: 3 3 source/locale/pl/LC_MESSAGES/nvda.po 1 file changed, 3 insertions(+), 3 deletions(-)
From translation svn revision: 72435
From translation svn revision: 72616 Authors: Ali Aslani <aslani.ali@gmail.com> Mohammadreza Rashad <mohammadreza5712@gmail.com> Stats: 1118 1118 user_docs/fa/userGuide.t2t 1 file changed, 1118 insertions(+), 1118 deletions(-)
From translation svn revision: 72616 Authors: Jani Kinnunen <janikinnunen340@gmail.com> Isak Sand <isak.sand@gmail.com> Stats: 2 2 source/locale/fi/symbols.dic 1 file changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 72616 Authors: Mongol NVDA-Translation <mongoliannvdatranslation@gmail.com> Stats: 294 511 source/locale/mn/LC_MESSAGES/nvda.po 1 file changed, 294 insertions(+), 511 deletions(-)
From translation svn revision: 72616 Authors: Ondrej Rosik <ondrej.rosik@gmail.com> Peter Vagner <peter.v@datagate.sk> Jan Kulik <jan.kulik.szsle@outlook.sk> Stats: 2 1 user_docs/sk/userGuide.t2t 1 file changed, 2 insertions(+), 1 deletion(-)
From translation svn revision: 72616
Fixes #14390 Summary of the issue: With the merging of pr #14070 which added sayall in tables, SayAll in Kindle for PC would fail to continue reading after turning the page. Technical: Some of the code in the nextLine method in sayAll was refacted into a nextLineImpl method. However, if nextLineImpl returned false, finish would be called and nextLIne would return. This would be correct for handling the case where there was no more text, or table cells, but not the case where the page has just been turned. In fact, text sayAll already called finish when there was no more text, so calling finish again was useless in the base case, but for page turns caused sayAll to abort prematurely after the page was turned. Description of user facing changes NVDA no longer fails to keep reading with sayAll after crossing a page boundary. Description of development approach In sayAll's nextLine method, removed the call to self.finish when nextLineImpl returns False, but ensured that table sayAll's nextLineImpl does call finish itself if there is no more table cells. In other words, the self.finish call has been moved into the specific nextLineImpl method where it is needed, rather than running more broadly.
merge rc to beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.