Skip to content

No longer install fake gettext and pgettext in unit tests before initializing languageHandler#14722

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
lukaszgo1:no_fake_gettext_in_unit_tests
Mar 20, 2023
Merged

No longer install fake gettext and pgettext in unit tests before initializing languageHandler#14722
michaelDCurran merged 1 commit into
nvaccess:masterfrom
lukaszgo1:no_fake_gettext_in_unit_tests

Conversation

@lukaszgo1

Copy link
Copy Markdown
Contributor

Link to issue number:

Related to #14660

Summary of the issue:

When executing unit tests we're installing fake gettext and pgettext functions. In normal usage this is not happening (languageHandler is responsible for setting localization support).

Description of user facing changes

None - this touches only unit tests.

Description of development approach

_ and pgettext are no longer installed in unit tests. It was also necessary to modify unit tests which verifies announcements of capital letters, in which we are using a fake translation. It was changed so that the translation restored after tests is the one created by languageHandler not the fake one as it was done previously.

Testing strategy:

Ensured that unit tests still pass.

Known issues with pull request:

None known

Change log entries:

None needed - test only change.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner March 16, 2023 15:04
@lukaszgo1 lukaszgo1 requested a review from seanbudd March 16, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants