No longer install fake gettext and pgettext in unit tests before initializing languageHandler#14722
Merged
michaelDCurran merged 1 commit intoMar 20, 2023
Conversation
…ializing languageHandler
michaelDCurran
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #14660
Summary of the issue:
When executing unit tests we're installing fake gettext and pgettext functions. In normal usage this is not happening (
languageHandleris responsible for setting localization support).Description of user facing changes
None - this touches only unit tests.
Description of development approach
_andpgettextare no longer installed in unit tests. It was also necessary to modify unit tests which verifies announcements of capital letters, in which we are using a fake translation. It was changed so that the translation restored after tests is the one created bylanguageHandlernot the fake one as it was done previously.Testing strategy:
Ensured that unit tests still pass.
Known issues with pull request:
None known
Change log entries:
None needed - test only change.
Code Review Checklist: