Report aria-haspopup dialog/grid/list/tree in Firefox and Chrome.#14709
Merged
Conversation
michaelDCurran
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8235.
Summary of the issue:
NVDA reports "sub menu" for all values of aria-haspopup, which is misleading at best.
Description of user facing changes
In Mozilla Firefox and Google Chrome, NVDA now reports when a control opens a dialog, grid, list or tree if the author has specified this using aria-haspopup.
Description of development approach
Testing strategy:
Tested with the test case in #8235. The correct message - "opens dialog", etc. - is reported when tabbing in focus mode, tabbing in browse mode, moving by line in browse mode and quick navigating in browse mode.
Known issues with pull request:
None.
Change log entries:
New features
In Mozilla Firefox and Google Chrome, NVDA now reports when a control opens a dialog, grid, list or tree if the author has specified this using aria-haspopup.
Code Review Checklist: