Fixed a string that was not translatable.#14691
Merged
Merged
Conversation
Collaborator
|
Why not change that to a .format call while you're at it?
My understanding was that we're trying to remove % substitutions wherever we
find them (all over the place).
|
Contributor
Author
It seems indeed that the trend is more to Regarding the current PR, keeping the string as is allows translators not to have to re-translate it. Let's wait for the feedback from NVAccess' review. |
seanbudd
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
This thread on the translators' mailing list.
Summary of the issue:
The string "has %s" is not translatable whereas it should.
This is due to the fact that the formatting has been included in the gettext (underscore function)'s argument.
Description of user facing changes
For translators: the translation of the string "has %s" should now be working.
Description of development approach
First call gettext
_(underscore) function, and then format the result.Testing strategy:
Manual test:
These strings have already been translated. Thus, test with the appveyor build or from source that translation is working:
nvda+d#14480 (paragraph "Comments")Known issues with pull request:
None
Change log entries:
Not needed for this small fix.
Code Review Checklist: