Link to issue number:

Fixes #8442.

Summary of the issue:

Authors sometimes misguidedly mark editable text as a live region. This results in typed characters being echoed even if the user has speak typed characters turned off.

Description of user facing changes

In Firefox and Chrome (and derivatives thereof), Characters will no longer be echoed while typing in an editable text that is incorrectly marked as a live region.

Description of development approach

1. Use COM smart pointers in winEventProcHook to improve readability and maintainability. It's probably worth merging this as a rebase or full merge so this is separated from the second change.
2. If an object has IA2_STATE_EDITABLE, ignore live region updates.

Testing strategy:

1. This appears to be fixed in Google Groups itself (the original report in NVDA echoes the contents of the Google Groups Compose edit box as each character is typed #8442), so I couldn't test it there.
2. Typed characters into the editor on https://pad.chapril.org/p/testing in Firefox Nightly with speak typed characters off. Without this fix, typed characters were echoed. With this fix, they were not.
3. Typed characters into the editor in this test case in Firefox Nightly and Chrome Canary with speak typed characters off:
   data:text/html,<input type="text" aria-live="polite">
   Without this fix, typed characters were echoed. With this fix, they were not.
4. Tested this test case in Firefox Nightly and Chrome Canary:
   data:text/html,<div id="live" aria-live="polite"></div><script>let n = 0; function update() { live.textContent = ++n; setTimeout(update, 1000); } update(); </script>
   Numbers were reported every second both before and after the fix as expected.

Known issues with pull request:

None.

Change log entries:

Bug fixes:

• In Mozilla Firefox and Google Chrome, typed characters are no longer reported in some text boxes even when speak typed characters is disabled.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.