Link to issue number:

Fixes #14663
Fix-up of #14557

Summary of the issue:

When reading text containing a non-regexp dictionary entry, if the replacement field contains some special characters (such as space, +, etc.), these characters are escaped with a backslash. Thus this backslash is heard in the text spoken by NVDA.

Description of user facing changes

No unappropriated backslash will be spoken by NVDA when the replacement field of a dictionary entry contains space or other special character.

Description of development approach

Use theString.replace('\\', '\\\\') instead of re.escape(theString).

Indeed, it was well documented in the doc of re.escape:

This function must not be used for the replacement string in sub() and subn(), only backslashes should be escaped.

Testing strategy:

Manual tests:

• STR in Strange behavior in dictionaries if replacement contains space #14663
• Tests in Fix regexp error message in dictionaries #14557
• STR in Unable to use backslash in the replacement value of dictionaries #14556

Known issues with pull request:

None

Change log entries:

None: fixing unreleased bug.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.