Fixes in change log for 2023.1#14662
Conversation
| There are many bug fixes, notably Windows 11 fixes. | ||
|
|
||
| eSpeak, LibLouis, Sonic rate boost and Unicode CLDR has been updated. | ||
| eSpeak, LibLouis, Sonic rate boost and Unicode CLDR have been updated. |
| Tivomatic Caiku Albatross 46/80 braille displays are now supported. | ||
|
|
||
| Support for ARM64 and AMD64 versions of Windows has improved. | ||
|
|
There was a problem hiding this comment.
Empty line to make two separate paragraphs
| - Emojis should now be reported in more languages. (#14433) | ||
| - The presence of an annotation is no longer missing in braille for some elements. (#13815) | ||
| - Fixed an issue where config changes not save correctly when changing between a "Default" option and the value of the "Default" option. (#14133) | ||
| - When configuring NVDA there will always be at least one key is defined as a NVDA key. (#14527) |
There was a problem hiding this comment.
- "is" removed
- "a" -> "an"
| Please refer to [the developer guide https://www.nvaccess.org/files/nvda/documentation/developerGuide.html#API] for information on NVDA's API deprecation and removal process. | ||
|
|
||
| - System test should now pass when run locally on non-English systems. (#13362) | ||
| - System tests should now pass when run locally on non-English systems. (#13362) |
There was a problem hiding this comment.
"test" -> "tests"
| - | ||
| - In ``[keyboard]`` section (#14528): | ||
| - ``useCapsLockAsNVDAModifierKey``, ``useNumpadInsertAsNVDAModifierKey``, ``useExtendedInsertAsNVDAModifierKey`` has been removed. | ||
| - ``useCapsLockAsNVDAModifierKey``, ``useNumpadInsertAsNVDAModifierKey``, ``useExtendedInsertAsNVDAModifierKey`` have been removed. |
|
@CyrilleB79 You might also want to get:
Add-ons will need to be re-tested and have their manifest updated.
Many ad-ons do not share a manifest.
Manifest -> manifests
|
See test results for failed build of commit ba61de140a |
Thanks. I was unsure about this one and had trusted native English speakers. |
See test results for failed build of commit ec3014ffff |
|
Note: the failing system test is completely unrelated. |
| == Changes for Developers == | ||
| Note: this is an Add-on API compatibility breaking release. | ||
| Add-ons will need to be re-tested and have their manifest updated. | ||
| Add-ons will need to be re-tested and have their manifests updated. |
There was a problem hiding this comment.
I think this change has been discussed before, and either sentence is fine. The current grammar can be read as "the [add-ons should] have their manifest updated".
If this new string is preferred, we need to update a template elsewhere
There was a problem hiding this comment.
I think this change has been discussed before, and either sentence is fine. The current grammar can be read as "the [add-ons should] have their manifest updated".
If this new string is preferred, we need to update a template elsewhere
Since "manifest" was used with singular form for 2021.1 and 2022.1 change log, I have reverted the change.
If ?VAccess and/or community want to change this, NVAccess should change their template as well and I will re-revert.
This reverts commit 58ebb47.
|
Regarding the question of whether "manifest" should be plural or singular (i.e.
do multiple add-ons share one manifest, or does manifest being singular agree
with the pronoun "their"):
I think I did submit a change on this in either 2022 or 2021, but it wasn't
accepted then for the same reason.
Here are a couple of questions on the subject, with interesting answers. My
opinion seems to be the more common one in the English community, but there
is a significant portion which holds @seanbudd's position as well.
https://www.englishforums.com/English/NounAfterTheir/brjhbr/post.htm
https://english.stackexchange.com/questions/551378/singular-or-plural-noun-after-their-when-subject-is-those-as-in-those-who
|
Preliminary note: This PR only fixes small typo in the change log. Since 2023.1 translation freeze has already started, it is not worth merging it. However in case a new translation freeze is decided for 2023.1 it could be worth merging it.
Link to issue number:
None
Summary of the issue:
Small typos found while reviewing the translation of the change log.
Description of user facing changes
See updates of the change log in this PR.
Description of development approach
N/A
Testing strategy:
Check the file generated by appVeyor.
Known issues with pull request:
Should only be merged if a new translation freeze is decided.
Change log entries:
N/A
Code Review Checklist: