Skip to content

Fixup #14531: TypeError: 'property' object is not iterable#14642

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:notIterable
Feb 17, 2023
Merged

Fixup #14531: TypeError: 'property' object is not iterable#14642
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:notIterable

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fix for #14531

Summary of the issue:

Error 'property' object is not iterable when enabling autodetect for the first time with Bluetooth on.

Description of user facing changes

None

Description of development approach

The detector was trying to save the bdDefsCache on the _DeviceInfoFfetcher class (not the instance).

Testing strategy:

Tested that NVDA no longer produces errors after a clean start with automatic detection on.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner February 16, 2023 06:44
@LeonarddeR LeonarddeR requested a review from seanbudd February 16, 2023 06:44
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit f20eeaaae3

@seanbudd seanbudd merged commit 5b49cac into nvaccess:master Feb 17, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Feb 17, 2023
@LeonarddeR LeonarddeR deleted the notIterable branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants