Skip to content

Fix up dash pronunciation in system tests after #13857#14640

Merged
seanbudd merged 5 commits into
masterfrom
fixupSysTests
Feb 16, 2023
Merged

Fix up dash pronunciation in system tests after #13857#14640
seanbudd merged 5 commits into
masterfrom
fixupSysTests

Conversation

@seanbudd

@seanbudd seanbudd commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Link to issue number:

Fixup of #13857

Summary of the issue:

#13857 was merged assuming the system test failures were random false positives.
#13857 changed symbol pronunciation of the dash symbol, and as such, relevant system tests had to be updated.

Description of user facing changes

None

Description of development approach

N/A

Testing strategy:

N/A

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

AppVeyorBot commented Feb 15, 2023

Copy link
Copy Markdown

See test results for failed build of commit 5b8211ebb2

@AppVeyorBot

AppVeyorBot commented Feb 15, 2023

Copy link
Copy Markdown

See test results for failed build of commit ca1004e626

@AppVeyorBot

AppVeyorBot commented Feb 16, 2023

Copy link
Copy Markdown

See test results for failed build of commit ca1004e626

seanbudd
seanbudd commented Feb 16, 2023
View reviewed changes
Comment thread tests/system/robot/symbolPronunciationTests.py Outdated
@AppVeyorBot

AppVeyorBot commented Feb 16, 2023

Copy link
Copy Markdown

See test results for failed build of commit 70cb1025e8

@AppVeyorBot

AppVeyorBot commented Feb 16, 2023

Copy link
Copy Markdown

See test results for failed build of commit 36aadc4862

@seanbudd seanbudd marked this pull request as ready for review February 16, 2023 02:32
@seanbudd seanbudd requested a review from a team as a code owner February 16, 2023 02:32
@seanbudd seanbudd merged commit 4b3735b into master Feb 16, 2023
@seanbudd seanbudd deleted the fixupSysTests branch February 16, 2023 02:42
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

4 participants

@seanbudd @AppVeyorBot @michaelDCurran @nvaccessAuto