Allow translators to specify row/column when reporting the end coordinate of a merged cell#14585
Merged
Merged
Conversation
…nate of a merged cell
Contributor
|
@CyrilleB79 your pull requests are good, hopefuly one day i see a pull request wich will add my suggestion to nvda from you: thanks |
michaelDCurran
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14581
Summary of the issue:
For some translators (Chinese ones at least), in the case of merged cell it would be better to report "column 2 to column 3" instead of "column 2 to 3" as we do today.
Today, NVDA uses 2 translatable strings to report the coordinates of a merged cell:
Description of user facing changes
Translators will now have two strings indicating the end coordinate of a merged cell, one for rows and one for columns.
Description of development approach
I just have used
.format(...)with named parameters. Defining strings with two parameters named differently allows to create 2 translatable strings instead of only one. As a side effect, it's also better for translators to have named parameters rather than just%swhich is not explicit.Note: using
pgettextwas another option, but with named parameters, it didn't turn out to be necessary.Testing strategy:
Manual test: Create po/pot file and check that we can translate separately the two strings indicating "row" or "column"
Known issues with pull request:
None
Change log entries:
Not deserving an entry.
Code Review Checklist: