Skip to content

Allow translators to specify row/column when reporting the end coordinate of a merged cell#14585

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:translatableStrings
Feb 1, 2023
Merged

Allow translators to specify row/column when reporting the end coordinate of a merged cell#14585
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:translatableStrings

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #14581

Summary of the issue:

For some translators (Chinese ones at least), in the case of merged cell it would be better to report "column 2 to column 3" instead of "column 2 to 3" as we do today.

Today, NVDA uses 2 translatable strings to report the coordinates of a merged cell:

  • for rows: "row %s" and "through %s"
  • for columns: "column %s" and and "through %s"

Description of user facing changes

Translators will now have two strings indicating the end coordinate of a merged cell, one for rows and one for columns.

Description of development approach

I just have used .format(...) with named parameters. Defining strings with two parameters named differently allows to create 2 translatable strings instead of only one. As a side effect, it's also better for translators to have named parameters rather than just %s which is not explicit.

Note: using pgettext was another option, but with named parameters, it didn't turn out to be necessary.

Testing strategy:

Manual test: Create po/pot file and check that we can translate separately the two strings indicating "row" or "column"

Known issues with pull request:

None

Change log entries:

Not deserving an entry.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@amirmahdifard

Copy link
Copy Markdown
Contributor

@CyrilleB79 your pull requests are good, hopefuly one day i see a pull request wich will add my suggestion to nvda from you: thanks

@CyrilleB79 CyrilleB79 marked this pull request as ready for review January 26, 2023 16:39
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner January 26, 2023 16:39
@CyrilleB79 CyrilleB79 requested a review from seanbudd January 26, 2023 16:39
@michaelDCurran michaelDCurran merged commit 79ad4f0 into nvaccess:master Feb 1, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Feb 1, 2023
@CyrilleB79 CyrilleB79 deleted the translatableStrings branch February 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splitting translatable strings for merged cells makes translation more flexible

4 participants