Link to issue number:

Fixes #14407

Summary of the issue:

When launching NVDA with parameter --lang=windows, an error occurs when openeing the General settings dialog.
This error probably occurs when Windows language is not in the list of languages supported by NVDA (even if I have not been able to test such Windows localization). This error also occurs when Windows provides language+region code ('fr_FR') whereas NVDA supports 'fr' more generally.

Description of user facing changes

For Windows language not directly supported by NVDA, use the language code as a description instead of a full text description.

Description of development approach

I have choosen to replace full text description by the language code when NVDA does not support windows language+region. This is the simplest approach.

For fr_FR, I may have implemented a fallback to 'fr', but this would just throw other corner cases for Windows languages completely unknown to NVDA. I believe that displaying full text language names in a few more cases do not deserve a much more complex implementation. The first goal is to be able to open the settings dialog.

Testing strategy:

Manual tests:
Launch NVDA with various arguments and open the General settings dialogs:

• --lang=Windows
• --lang=fr
• --lang=it
• --lang=pt_BR
• no --lang parameter

Known issues with pull request:

Language description of command line argument is not always a full description.

Change log entries:

Bug fixes
When NVDA is launched with --lang=Windows parameter, it is again to open General settings dialog. (#14407)

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.