Fix dead "startupShutdown" link in technical docs#14567
Merged
Conversation
Found a dead link when reading the documentation, this should be fixed now.
Contributor
|
Hi, could you mind filing out the pull request template please? That way reviewers can figure out what’s going on a bit better. Thanks.
|
Contributor
Author
|
Apologies, I thought that outline would be noise for reviewers since this is a relatively small change to documentation, but it should be filled out now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
N/A
Summary of the issue:
Previously, in the "Technical Design Overview" document, the startupShutdown link under the Launcher heading didn't work.
Description of user facing changes
Now, the startupShutdown link should correctly link to NVDA Starting and Exiting outline page.
Description of development approach
N/A
Testing strategy:
Used Github's "Preview" feature when editing
technicalDesignOverview.mdfile to make sure the link opens up correctly.Known issues with pull request:
N/A
Change log entries:
N/A - this is a small technical documentation fix.
Code Review Checklist: