Skip to content

Windows 11 clipboard history: disable browse mode by default#14510

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
josephsl:i14508Win11ClipboardNoBrowseMode
Jan 4, 2023
Merged

Windows 11 clipboard history: disable browse mode by default#14510
seanbudd merged 3 commits into
nvaccess:masterfrom
josephsl:i14508Win11ClipboardNoBrowseMode

Conversation

@josephsl

@josephsl josephsl commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #14508

Summary of the issue:

Browse mode is enabled in Windows 11 clipboard history when it should not be.

Description of user facing changes

Users will be able to tab through various parts of Windows 11 lipboard history, specificlaly to access menu items such as pinning and unpinning items.

Description of development approach

"Disable browse mode" flag is set to True in emoji panel app module.

Testing strategy:

Manual testing:

  1. In Windows 11, copy text to the clipboard.
  2. Open an app such as Notepad and press Windows+V.
  3. When clipboard history opens, press Tab to move through the interface. Make sure NVDA can announce menu items such as pin.

Known issues with pull request:

None

Change log entries:

Bug fixes:

In Windows 11, clipboard history menu items such as "pin item" can be accessed. (Re #14508)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

…cess#14508.

Windows 11 clipboard history is treated as a web document rather than an application window. Among other things, this prevents access to clipboard menu such as removing pinned items. Therefore, disable browse mode by default.
@josephsl josephsl requested a review from a team as a code owner January 4, 2023 07:52
@josephsl josephsl requested a review from seanbudd January 4, 2023 07:52
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 0c001e3ffa

@seanbudd seanbudd merged commit 332275a into nvaccess:master Jan 4, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Jan 4, 2023
@josephsl josephsl deleted the i14508Win11ClipboardNoBrowseMode branch January 19, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows 11 clipboard history: disable browse mode by default

4 participants