Skip to content

Move _TrackNVDAInitialization to NVDAState#14491

Merged
seanbudd merged 1 commit into
masterfrom
move_TrackNVDAInitialization
Jan 4, 2023
Merged

Move _TrackNVDAInitialization to NVDAState#14491
seanbudd merged 1 commit into
masterfrom
move_TrackNVDAInitialization

Conversation

@seanbudd

@seanbudd seanbudd commented Dec 30, 2022

Copy link
Copy Markdown
Member

Link to issue number:

Summary of the issue:

_TrackNVDAInitialization was created on rc before NVDAState was created, while NVDAState had been implemented for beta/alpha. As such, it was flagged to be moved once 2022.3.3 was completed.

Description of user facing changes

None

Description of development approach

Code move

Testing strategy:

None

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner December 30, 2022 00:24
@seanbudd seanbudd requested a review from feerrenrut December 30, 2022 00:24
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit b9b153a59e

@seanbudd seanbudd requested review from michaelDCurran and removed request for feerrenrut January 4, 2023 04:31
@seanbudd seanbudd merged commit 9d9928a into master Jan 4, 2023
@seanbudd seanbudd deleted the move_TrackNVDAInitialization branch January 4, 2023 04:51
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants