Skip to content

No longer try to return to first task switch item#14343

Merged
feerrenrut merged 2 commits into
masterfrom
sysTest-taskSwitchFix
Nov 14, 2022
Merged

No longer try to return to first task switch item#14343
feerrenrut merged 2 commits into
masterfrom
sysTest-taskSwitchFix

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Also track row column announcement accurately.

Link to issue number:

Fixes: #14342

Summary of the issue:

When using the task switcher to navigate to the SUT application window, it is unnecessary to return to the first item in the task switcher. It is unlikely that there will be more than the current limit of 10 windows open on appveyor. If the test needs to return to the first window it will cycle through and return to the first row and column.

Description of user facing changes

None

Description of development approach

  • Adds more debug logging to the robot framework log.
  • Always cycle forwards through the task switcher.
  • All failure paths send escape to dismiss the task switcher.
  • Consider variations in task switcher content:
    • A single item. Unlikely during the tests, there should be the SUT application and the appveyor build agent.
    • A single row of items, most likely. Row is only reported when the row number changes. "column 1" indicates cycling back to the first item.
    • Multiple rows of items, unlikely on build systems, more likely on dev systems.

Testing strategy:

  • Ran a symbols test locally, closing the notepad window as the test starts so that the window cannot be found. Observed the behavior with different numbers of windows open.
  • Appveyor builds.

Known issues with pull request:

None.

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

Also track row column announcement accurately.
@feerrenrut feerrenrut marked this pull request as ready for review November 7, 2022 09:01
@feerrenrut feerrenrut requested a review from a team as a code owner November 7, 2022 09:01
@feerrenrut feerrenrut requested a review from seanbudd November 7, 2022 09:01

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, minor string changes suggested

Comment thread tests/system/libraries/WindowsLib.py Outdated
Comment thread tests/system/libraries/WindowsLib.py
@AppVeyorBot

This comment was marked as outdated.

@feerrenrut

Copy link
Copy Markdown
Contributor Author

Last test failure seems unrelated. Documented here: #14353
Re-building PR.

@AppVeyorBot

This comment was marked as outdated.

@feerrenrut feerrenrut merged commit 0fc81e9 into master Nov 14, 2022
@feerrenrut feerrenrut deleted the sysTest-taskSwitchFix branch November 14, 2022 08:02
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Nov 14, 2022
@feerrenrut

Copy link
Copy Markdown
Contributor Author

Test failures from #14343 (comment), for this build have been investigated here: #14372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: Symbols tests

4 participants