Skip to content

restore API import to core.main on beta#14330

Merged
seanbudd merged 2 commits into
betafrom
restore-api-import
Nov 3, 2022
Merged

restore API import to core.main on beta#14330
seanbudd merged 2 commits into
betafrom
restore-api-import

Conversation

@seanbudd

@seanbudd seanbudd commented Nov 3, 2022

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

#14301 moved an api import from core.main as it was otherwise unused
#14050 introduced a usage of api to core.main to beta
This means that api was used without being imported on beta and master.

Description of user facing changes

None

Description of development approach

Fix import error

Testing strategy:

Exit NVDA, check log for error

Known issues with pull request:

None

Change log entries:

None, unreleased bug

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

#14050 introduced a usage of api to core.main to beta\n#14301 moved the api import from core.main as it was otherwise unused on rc
@seanbudd seanbudd requested a review from a team as a code owner November 3, 2022 00:18
@seanbudd seanbudd requested review from feerrenrut and removed request for a team November 3, 2022 00:18
@seanbudd seanbudd added this to the 2022.4 milestone Nov 3, 2022
@seanbudd seanbudd self-assigned this Nov 3, 2022
@seanbudd seanbudd merged commit 48caf54 into beta Nov 3, 2022
@seanbudd seanbudd deleted the restore-api-import branch November 3, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants