Fix error in UIA focus event handler when NVDAObject can't be created#14314
Merged
Conversation
seanbudd
approved these changes
Oct 31, 2022
See test results for failed build of commit 5dacdb4fe1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix regression introduced in pr #14256
Summary of the issue:
Sometimes a UIA focus event handler can't create an NVDAObject for the element being focused. Normally, in this situation, the event would be silently dropped.
However, with the introduction of extra debugging for UIA events in pr #14256, a return was accidently removed, which meant that the shouldAllowUIAFocusEvent attribute tried to be looed up on the None (failed NVDAObject). This caused a noisy traceback in the log at level error.
Description of user facing changes
A noisy error traceback is no longer produced when NVDA cannot handle certain broken UIA focus events.
Description of development approach
Make sure to return if instantiating the NVDAObject produces None.
Testing strategy:
Run NVDA for an hour or so performing normal daily tasks. Previously the error would have been seen multiple times.
Known issues with pull request:
None known.
Change log entries:
None needed - regression only in master.
New features
Changes
Bug fixes
For Developers
Code Review Checklist: