Fix-up #14070: No more error at edge of table with MSHtml#14298
Merged
Conversation
See test results for failed build of commit b5601d78ba |
seanbudd
previously approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened against beta branch since it fixes a non-released code.
Link to issue number:
None
Summary of the issue:
In MSHtml container, e.g. NVDA's browseable message, the table edge is not reported. The following error is found instead:
Description of user facing changes
No more error reported at edge and the edge is reported.
Description of development approach
The dataclass
documentBase._TableCellwas added in #14070. More specifically,DocumentWithTableNavigation._getTableCellCoordsnow returns_TableCell. But some usages of the return of this function have been forgotten.This PR fixes this.
Testing strategy:
Manual testing:
In the console, paste the following script:
Then navigate in the table with all possible gestures:
Known issues with pull request:
None
Change log entries:
Not needed, unreleased bug.
Code Review Checklist: