Prevent double beep or 'cap' announcement with delayed character descriptions#14271
Merged
Conversation
feerrenrut
reviewed
Oct 19, 2022
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Why make this method configurable?
If it isn't supporting a use case, it's introducing needless complexity.
Member
Author
The way the function is named implies it is more generic than it should be. In a follow up PR I think we should consider moving the 2 character description functions to a new file in |
Member
Author
|
I have made the approach simpler |
feerrenrut
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14239
Summary of the issue:
There are 3 settings for notifying a user of a capital letter. There is "beep", announce 'cap', and/or shift pitch for capitals.
When navigating by character, there is already a beep or "cap" announcement.
When the delayed character description occurs, another beep or "cap" announcement occurs.
There is no need for a secondary beep or "cap" announcement when announcing the the delayed character description.
The cap pitch change may be useful, as a pitch change may be harder to notice, and continuing the shifted pitch is more intuitive.
Description of user facing changes
When beep or announce 'cap' for capitals is enabled with delayed character descriptions, the descriptions do not beep or announce 'cap' twice.
Description of development approach
Disable beeping and announcing 'cap' for delayed character descriptions.
Testing strategy:
Tested the STR in #14239 with combinations of the 4 settings involved (beep, pitch, 'cap' and delayed character descriptions).
Known issues with pull request:
None
Change log entries:
Bug fixes
Code Review Checklist: