Skip to content

Fixed an issue where symbol repetition was not correctly reported by the synthesizer#14266

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixCharCount
Oct 18, 2022
Merged

Fixed an issue where symbol repetition was not correctly reported by the synthesizer#14266
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixCharCount

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Read the following line with OneCore (e.g. Zira) and symbol level all:
What is USD????

I can hear:
"What is four US dollars question"

Instead I expect
"What is USD four question"

The issue is due to the fact that the synth interprets "USD 4" as "four dollars". Instead, the repetition of "question" should not handled with the rest of the text by the synth but reported as is.

The impacted synthesizers are:

  • OneCore
  • SAPI5
  • IBMTTS

On the contrary, eSpeak is not impacted. Probably because it does not handle internally expressions such as "USD 4".

Description of user facing changes

The user should not hear anymore issues when reporting repeated symbols.

Description of development approach

Two spaces are added instead of only one between the rest of the text.

Testing strategy:

Manual test with the expression in this PR.

Known issues with pull request:

None.

Change log entries:

IMO, a such small bugfix does not deserve an entry. If you disagree, I can writre something for the "Bugfixes" section.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 7964d751c7

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Failing test is "lien Robot.symbolPronunciationTests.tableHeaderSymbols".
Since it is also failing in #14267 where it is completely unrelated, I think I can ignore it also here. Do you confirm this?

@CyrilleB79 CyrilleB79 marked this pull request as ready for review October 18, 2022 06:38
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner October 18, 2022 06:38
@CyrilleB79 CyrilleB79 requested a review from seanbudd October 18, 2022 06:38
@seanbudd seanbudd merged commit 49a7741 into nvaccess:master Oct 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 18, 2022
@CyrilleB79 CyrilleB79 deleted the fixCharCount branch October 19, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants