Fixed an issue where symbol repetition was not correctly reported by the synthesizer#14266
Merged
Merged
Conversation
See test results for failed build of commit 7964d751c7 |
Contributor
Author
|
Failing test is "lien Robot.symbolPronunciationTests.tableHeaderSymbols". |
seanbudd
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Read the following line with OneCore (e.g. Zira) and symbol level all:
What is USD????
I can hear:
"What is four US dollars question"
Instead I expect
"What is USD four question"
The issue is due to the fact that the synth interprets "USD 4" as "four dollars". Instead, the repetition of "question" should not handled with the rest of the text by the synth but reported as is.
The impacted synthesizers are:
On the contrary, eSpeak is not impacted. Probably because it does not handle internally expressions such as "USD 4".
Description of user facing changes
The user should not hear anymore issues when reporting repeated symbols.
Description of development approach
Two spaces are added instead of only one between the rest of the text.
Testing strategy:
Manual test with the expression in this PR.
Known issues with pull request:
None.
Change log entries:
IMO, a such small bugfix does not deserve an entry. If you disagree, I can writre something for the "Bugfixes" section.
Code Review Checklist: