Skip to content

Complete setup before modifying NVDA config#14263

Merged
feerrenrut merged 1 commit into
masterfrom
systest-configAfterSetup
Oct 20, 2022
Merged

Complete setup before modifying NVDA config#14263
feerrenrut merged 1 commit into
masterfrom
systest-configAfterSetup

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

Splitting up PR #14054

Summary of the issue:

Some config can affect the way the test samples are prepared, E.G. moving focus / review to the start location.

Description of user facing changes

None

Description of development approach

For all tests that modify NVDA config, ensure this happens after the initial set up is completed.
Introduce a new helper to allow modifying multiple settings at once.

Testing strategy:

System tests:

  • locally
  • Appveyor

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

Some config can affect the way the test samples are prepared,
E.G. moving focus / review to the start location.
@feerrenrut feerrenrut marked this pull request as ready for review October 19, 2022 08:48
@feerrenrut feerrenrut requested a review from a team as a code owner October 19, 2022 08:48
@feerrenrut feerrenrut requested a review from seanbudd October 19, 2022 08:48
@feerrenrut feerrenrut merged commit 164c378 into master Oct 20, 2022
@feerrenrut feerrenrut deleted the systest-configAfterSetup branch October 20, 2022 08:30
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants