Skip to content

Prevent Chrome 'session crashed bubble'#14262

Merged
feerrenrut merged 12 commits into
masterfrom
systest-preventChromeCrashBubbles
Oct 21, 2022
Merged

Prevent Chrome 'session crashed bubble'#14262
feerrenrut merged 12 commits into
masterfrom
systest-preventChromeCrashBubbles

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Oct 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note, this PR is stacked against PR #14260

Link to issue number:

Splitting up PR #14054

Summary of the issue:

When Chrome crashes, it shows a bubble informing of the crash when it restarts.
The bubble takes focus and interferes with subsequent tests.

It is rare that this happens, but it can cause confusion when trying to investigate.

Description of user facing changes

None

Description of development approach

Start Chrome with parameter to prevent the bubble.

Testing strategy:

Unable to reliably test this locally, relying on the description of available params for Chrome.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@feerrenrut
Open chrome prior to system tests
0756cbb 
Theory: Chrome is busy with post install tasks, so start chrome in the
background ahead of the tests.

The first system test to run that requires chrome occasionally fails.
This has been replicated on developer machines after chrome updates,
however it is difficult to reproduce, and difficult to detect/recover-from
in an automated way.
It may be possible to handle this better within NVDA, however it seems
to actually affect users infrequently, and they seem to be able to
recover by waiting a few seconds and de/refocus chrome.
In the mean time, the system tests failing delays development.
@feerrenrut
Provide central Chrome start args source
9d85622
@feerrenrut
Merge remote-tracking branch 'origin/master' into systest-startChrome…
0acfae7 
…Early
@feerrenrut
Add note about first start chrome args
7aa8961
@feerrenrut
fix bad merge
d0fe1c2 
 --lang=en-US was duplicated
@feerrenrut
prevent chrome session crashed bubble
38fcffb
@feerrenrut feerrenrut force-pushed the systest-preventChromeCrashBubbles branch from 779ca0c to 38fcffb Compare October 19, 2022 08:44
@feerrenrut feerrenrut changed the base branch from master to systest-startChromeEarly October 19, 2022 08:44
@feerrenrut feerrenrut marked this pull request as ready for review October 19, 2022 08:45
@feerrenrut feerrenrut requested a review from a team as a code owner October 19, 2022 08:45
@feerrenrut feerrenrut requested review from seanbudd and removed request for a team October 19, 2022 08:45
@feerrenrut feerrenrut mentioned this pull request Oct 19, 2022
Merged
6 tasks
seanbudd
seanbudd approved these changes Oct 20, 2022
View reviewed changes
Comment thread tests/system/libraries/_chromeArgs.py Outdated
Comment thread tests/system/libraries/_chromeArgs.py Outdated
Base automatically changed from systest-startChromeEarly to master October 21, 2022 06:32
@feerrenrut feerrenrut merged commit 9a30254 into master Oct 21, 2022
@feerrenrut feerrenrut deleted the systest-preventChromeCrashBubbles branch October 21, 2022 10:32
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

component/system-testing

Projects

None yet

Milestone

2023.1

Development

Successfully merging this pull request may close these issues.

3 participants

@feerrenrut @seanbudd @nvaccessAuto