Conversation
Seeing focus / nav / browsemode during tests can help some developers with debugging issues with the tests.
Contributor
Author
|
Given concerns about how this change affects timing, I intend to merge this PR after the other system test PRs |
Contributor
|
Some questions on this PR:
|
Contributor
Author
Happy for this to happen. I just started with the most commonly used config.
|
seanbudd
approved these changes
Dec 19, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Splitting up PR #14054
Summary of the issue:
When a system test fails a screenshot is captured.
However, this does not make it clear where the focus/ nav / virtual cursor is positioned.
Description of user facing changes
None
Description of development approach
Seeing focus / nav / virtual cursor during tests can help some developers with debugging issues with the tests.
Testing strategy:
Used locally.
Known issues with pull request:
May increase the time system tests take.
Change log entries:
None
Code Review Checklist: