Skip to content

Log the source of the error when the profile activation fails#14237

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:profileActivationError
Oct 12, 2022
Merged

Log the source of the error when the profile activation fails#14237
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:profileActivationError

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Issue found while working on #14233 (testing).

Link to issue number:

None

Summary of the issue:

When an error occurs while switching profile manually, a message box indicates that there has been an error, but nothing in the message box nor in the log indicates the source of error (no traceback...).

Description of user facing changes

When profile switching fails, the traceback of the error is logged.

Description of development approach

Added the log

Testing strategy:

Manual testing:

  • Created a new profile
  • Manually edited the file to make it invalid, e.g. remove "]" in a section name.
  • Manually activate the profile
  • Check the log

Known issues with pull request:

None

Change log entries:

Do not deserve change log.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review October 11, 2022 20:13
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner October 11, 2022 20:13
@CyrilleB79 CyrilleB79 requested a review from seanbudd October 11, 2022 20:13
@seanbudd seanbudd merged commit 5cd2fc6 into nvaccess:master Oct 12, 2022
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 12, 2022
@CyrilleB79 CyrilleB79 deleted the profileActivationError branch October 12, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants