Fix text selection with NVDA+f10 key on Java applications#14164
Merged
seanbudd merged 5 commits intoSep 20, 2022
Conversation
seanbudd
reviewed
Sep 19, 2022
| @@ -566,7 +566,7 @@ def getCurrentAccessibleValueFromContext(self): | |||
| return buf.value | |||
|
|
|||
| def selectTextRange(self,start,end): | |||
Member
There was a problem hiding this comment.
Can you confirm these type annotations are correct?
Suggested change
| def selectTextRange(self,start,end): | |
| def selectTextRange(self, start: int, end: int) -> None: |
Contributor
Author
There was a problem hiding this comment.
Thanks, I checked on the API docs and added the type information.
Member
|
I've confirmed these parameters seem correct according to the API Docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14163
Summary of the issue:
NVDA cannot select text in Java applications with the
NVDA+f10gesture.Description of user facing changes
NVDA can now select text using the
NVDA+f10gesture on Java applications.Description of development approach
This pull request adds the missing parameters to the
selectTextRangefunction.Testing strategy:
Tested on IntelliJ idea 2022.1.4 by performing the gesture.
Known issues with pull request:
Change log entries:
New features
Changes
Bug fixes
- NVDA can now select text using the ``NVDA+f10`` keyboard shortcut on Java applications (#14163)For Developers
Code Review Checklist: