Skip to content

Update eSpeak to 735ecdb8#14118

Merged
seanbudd merged 2 commits into
masterfrom
updateEspeak
Sep 12, 2022
Merged

Update eSpeak to 735ecdb8#14118
seanbudd merged 2 commits into
masterfrom
updateEspeak

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 9, 2022

Copy link
Copy Markdown
Member

Link to issue number:

Closes #13572
Closes #12952

Summary of the issue:

Janitorial update of eSpeak.
Fixes a long standing issue with Mandarin pronunciation of Latin characters.

Description of user facing changes

eSpeak is updated

Description of development approach

Followed instructions in include/espeak.md.
Checked the following diffs.

cd include/espeak
git diff 0dbe7182 f9193330 src/windows/config.h
git diff 0dbe7182 f9193330 Makefile.am

Testing strategy:

Tested eSpeak after building.

Known issues with pull request:

None

Change log entries:

- eSpeak NG has been updated to 1.52-dev commit ``f9193330``. (#14060, #14079, #14117)
  - Fixed reporting of Latin characters when using Mandarin. (#12952, #13572)
  -

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 9, 2022 01:15
@seanbudd seanbudd requested a review from feerrenrut September 9, 2022 01:15
@seanbudd

seanbudd commented Sep 9, 2022

Copy link
Copy Markdown
Member Author

@cary-rowen - can you confirm this PR description and changelog entry is correct?

@AppVeyorBot

AppVeyorBot commented Sep 9, 2022

Copy link
Copy Markdown
  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 1275469f09

@cary-rowen

cary-rowen commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

this PR description and changelog is well.
But the CI build seems to time out and fail.

@seanbudd seanbudd self-assigned this Sep 9, 2022
@codeofdusk

codeofdusk commented Sep 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@seanbudd Can we update to latest master please? I've had a few more pronunciation fixes merged.

@seanbudd seanbudd requested a review from feerrenrut September 12, 2022 01:37
@seanbudd seanbudd changed the title Update eSpeak to f9193330 Update eSpeak to 735ecdb8 Sep 12, 2022
@seanbudd

seanbudd commented Sep 12, 2022

Copy link
Copy Markdown
Member Author

@codeofdusk - I have bumped eSpeak again. However, unless 2022.4 gets delayed again, or there is an issue with the new commit of eSpeak, I don't see us updating eSpeak again for 2022.4

@feerrenrut - I have re-requested your review. There are no relevant changes in the Makefile since the previously reviewed commit.

@seanbudd seanbudd merged commit 3454228 into master Sep 12, 2022
@seanbudd seanbudd deleted the updateEspeak branch September 12, 2022 02:39
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 12, 2022
@cary-rowen cary-rowen mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@feerrenrut feerrenrut feerrenrut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seanbudd seanbudd

Labels

None yet

Projects

None yet

Milestone

2022.4

6 participants

@seanbudd @AppVeyorBot @cary-rowen @codeofdusk @feerrenrut @nvaccessAuto