Skip to content

Change selectively and globally to selective and global respectively in the selective registration UI#14107

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:selectiveuia-adv-to-adj
Sep 6, 2022
Merged

Change selectively and globally to selective and global respectively in the selective registration UI#14107
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:selectiveuia-adv-to-adj

Conversation

@codeofdusk

Copy link
Copy Markdown
Contributor

Link to issue number:

Follow-up of #13297.

Summary of the issue:

In the advanced settings panel, the config options were referred to as "selectively" and "globally", but the config spec uses "selective" and "global", which makes more sense ("selective registration" vs "selectively registration").

Description of how this pull request fixes the issue:

Update the UI. No other functional changes.

Testing strategy:

N/A

Known issues with pull request:

None known

Change log entries:

None needed (unreleased functionality)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

…in the selective registration UI, for consistency with the config spec
@codeofdusk codeofdusk requested review from a team as code owners September 5, 2022 20:12
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit e6a950d83e

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit e6a950d83e

@seanbudd seanbudd merged commit 7db6d59 into nvaccess:master Sep 6, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants