Skip to content

Catch exception when expanding to page in move to next page script#14029

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:review-page-catch-expand
Aug 18, 2022
Merged

Catch exception when expanding to page in move to next page script#14029
seanbudd merged 1 commit into
nvaccess:masterfrom
codeofdusk:review-page-catch-expand

Conversation

@codeofdusk

Copy link
Copy Markdown
Contributor

Link to issue number:

#14021 (comment)

Summary of the issue:

In the Thunderbird message list on some systems, move by page appears to work, but expansion doesn't.

Description of how this pull request fixes the issue:

Widen scope of try/except to catch this case.

Testing strategy:

Verified no regressions in move by page functionality.

Known issues with pull request:

None known.

Change log entries:

None needed.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@codeofdusk codeofdusk requested a review from a team as a code owner August 17, 2022 18:45
@codeofdusk codeofdusk requested a review from seanbudd August 17, 2022 18:45
@seanbudd seanbudd merged commit 5ce4509 into nvaccess:master Aug 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 18, 2022
@burmancomp

Copy link
Copy Markdown
Contributor

This resolves the problem in my system. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants