Skip to content

Enable rdp via appveyor settings#14004

Merged
seanbudd merged 3 commits intobetafrom
enableRdpViaAppveyorSettings
Aug 17, 2022
Merged

Enable rdp via appveyor settings#14004
seanbudd merged 3 commits intobetafrom
enableRdpViaAppveyorSettings

Conversation

@feerrenrut
Copy link
Copy Markdown
Contributor

Link to issue number:

Related to #13983

Summary of the issue:

Sometimes the Appveyor environment is unpredictable, recently Docker Desktop opens a window asking for feedback. This window takes the foreground which subsequently results in applications started from the system test being unable to take focus back.

Description of user facing changes

For developers:
The intention is to fix this foreground issue separately, which may take some time. Until then, and for other issues in the future, make it easier to enable RDP as required.

The details of the connection show in the build log at the start of the build (after cloning NVDA)

Description of development approach

When the environment variable for an RDP password is set (via the Appveyor settings), the appveyor RDP script will be run.
NV Access developers will need to set (and unset) this environment variable as required.

Testing strategy:

Started two builds:

  • With the environment variable set, the RDP server starts, and I was able to connect to it.
  • Without the environment variable set, the RDP server wasn't started.

Known issues with pull request:

This requires developers to remember to remove the environment variable when they are done.

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut requested a review from a team as a code owner August 10, 2022 10:42
@feerrenrut feerrenrut requested review from seanbudd and removed request for a team August 10, 2022 10:42
@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit e869277f3b

@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit e869277f3b

seanbudd
seanbudd previously approved these changes Aug 10, 2022
@feerrenrut
Copy link
Copy Markdown
Contributor Author

To prevent the focus error (caused by Docker Desktop asking for feedback):

  • Connect via RDP during the build
  • Close the feedback window
  • Set focus to (click on) the Appveyor window (this needs focus so that it can create new processes with focus).

@feerrenrut
Copy link
Copy Markdown
Contributor Author

There are also other intermittent issues affecting the build, I'll resolve these in a separate PR.

@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit f448d0cf53

@LeonarddeR
Copy link
Copy Markdown
Collaborator

Has this been reported to Appveyor? I assume this can affect more system tests of other projects.

@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit a46ecbe034

@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit a46ecbe034

@seanbudd seanbudd merged commit abbf5a6 into beta Aug 17, 2022
@seanbudd seanbudd deleted the enableRdpViaAppveyorSettings branch August 17, 2022 05:11
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 17, 2022
@seanbudd seanbudd modified the milestones: 2022.4, 2022.3 Aug 17, 2022
@feerrenrut feerrenrut mentioned this pull request Aug 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants