Merged
Conversation
See test results for failed build of commit e869277f3b |
See test results for failed build of commit e869277f3b |
lukaszgo1
reviewed
Aug 10, 2022
seanbudd
reviewed
Aug 10, 2022
seanbudd
previously approved these changes
Aug 10, 2022
Contributor
Author
|
To prevent the focus error (caused by Docker Desktop asking for feedback):
|
Contributor
Author
|
There are also other intermittent issues affecting the build, I'll resolve these in a separate PR. |
See test results for failed build of commit f448d0cf53 |
Collaborator
|
Has this been reported to Appveyor? I assume this can affect more system tests of other projects. |
seanbudd
approved these changes
Aug 12, 2022
See test results for failed build of commit a46ecbe034 |
See test results for failed build of commit a46ecbe034 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #13983
Summary of the issue:
Sometimes the Appveyor environment is unpredictable, recently Docker Desktop opens a window asking for feedback. This window takes the foreground which subsequently results in applications started from the system test being unable to take focus back.
Description of user facing changes
For developers:
The intention is to fix this foreground issue separately, which may take some time. Until then, and for other issues in the future, make it easier to enable RDP as required.
The details of the connection show in the build log at the start of the build (after cloning NVDA)
Description of development approach
When the environment variable for an RDP password is set (via the Appveyor settings), the appveyor RDP script will be run.
NV Access developers will need to set (and unset) this environment variable as required.
Testing strategy:
Started two builds:
Known issues with pull request:
This requires developers to remember to remove the environment variable when they are done.
Change log entries:
None
Code Review Checklist: