Skip to content

Split up scriptHandler.findScript#13989

Merged
seanbudd merged 7 commits into
masterfrom
improveScriptHandlerTyping
Aug 22, 2022
Merged

Split up scriptHandler.findScript#13989
seanbudd merged 7 commits into
masterfrom
improveScriptHandlerTyping

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 5, 2022

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

scriptHandler.findScript is considered too complex.
Therefore it should be broken up into smaller functions.

Description of user facing changes

None

Description of development approach

Added typing to related objects.
Split up scriptHandler.findScript so it is more modular.

Testing strategy:

Tested various input gestures.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested a review from a team as a code owner August 5, 2022 06:42
@seanbudd seanbudd requested a review from feerrenrut August 5, 2022 06:42
@seanbudd seanbudd changed the title Improve script handler typing Split up scriptHandler.findScript Aug 5, 2022
@seanbudd seanbudd marked this pull request as draft August 8, 2022 06:36
@seanbudd seanbudd added merge-early Merge Early in a developer cycle audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers labels Aug 8, 2022
@seanbudd seanbudd marked this pull request as ready for review August 19, 2022 05:30
Comment thread source/scriptHandler.py
@seanbudd seanbudd requested a review from feerrenrut August 22, 2022 00:57
@seanbudd seanbudd merged commit b383765 into master Aug 22, 2022
@seanbudd seanbudd deleted the improveScriptHandlerTyping branch August 22, 2022 04:20
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers merge-early Merge Early in a developer cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants