Skip to content

Use line as a unit for which say all is moved in rich edit controls#13971

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:sayAllPerLineInRichEdit
Aug 2, 2022
Merged

Use line as a unit for which say all is moved in rich edit controls#13971
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:sayAllPerLineInRichEdit

Conversation

@lukaszgo1

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #13420
Fixes #9179

Summary of the issue:

When in say all NVDA moves caret by the unit specified as a RREADINGCHUNK for a given text info implementation. In most text info implementations it defaults to line, however in ITextDocumentTextInfo it was set to sentence. While it probably results in smoother reading for literary text written in language where TOM can split into sentences properly, in text's such as log or for languages without clear concept of sentence such as Chinese it results in caret not following spoken text since it is moved to the current position only when the sentence ending is reached.

Description of user facing changes

Say all both for review and system cursor moves by line in Rich Edit controls such as WordPad or NVDA's log viewer.

Description of development approach

for ITextDocumentTextInfo textInfos.UNIT_READINGCHUNK has been set to line.

Testing strategy:

Made sure that say all both with system caret and review cursor follows spoken text in QRead and log viewer.

Known issues with pull request:

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@jcsteh

jcsteh commented Aug 1, 2022 via email

Copy link
Copy Markdown
Contributor

@seanbudd seanbudd merged commit 462365a into nvaccess:master Aug 2, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 2, 2022
@lukaszgo1 lukaszgo1 deleted the sayAllPerLineInRichEdit branch August 2, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants