Use line as a unit for which say all is moved in rich edit controls#13971
Merged
Conversation
Contributor
|
I don't recall this specific case, but usually, when we used sentence, it
was either because the underlying implementation didn't support line at the
time or because line caused a performance problem. If it works now, it
seems reasonable to change it for consistency if nothing else.
|
seanbudd
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13420
Fixes #9179
Summary of the issue:
When in say all NVDA moves caret by the unit specified as a
RREADINGCHUNKfor a given text info implementation. In most text info implementations it defaults to line, however inITextDocumentTextInfoit was set to sentence. While it probably results in smoother reading for literary text written in language where TOM can split into sentences properly, in text's such as log or for languages without clear concept of sentence such as Chinese it results in caret not following spoken text since it is moved to the current position only when the sentence ending is reached.Description of user facing changes
Say all both for review and system cursor moves by line in Rich Edit controls such as WordPad or NVDA's log viewer.
Description of development approach
for
ITextDocumentTextInfotextInfos.UNIT_READINGCHUNKhas been set to line.Testing strategy:
Made sure that say all both with system caret and review cursor follows spoken text in QRead and log viewer.
Known issues with pull request:
textInfos.UNIT_READINGCHUNKwas set to the sentence in the first place, perhaps @michaelDCurran or @jcsteh would be able to recall the reasonChange log entries:
Bug fixes
Code Review Checklist: