Skip to content

winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium). Re #13845#13963

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
josephsl:i13845win10
Jul 29, 2022
Merged

winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium). Re #13845#13963
seanbudd merged 1 commit into
nvaccess:masterfrom
josephsl:i13845win10

Conversation

@josephsl

Copy link
Copy Markdown
Contributor

Link to issue number:

Partially closes #13845
Windows 10 part of #13867

Summary of the issue:

Recognize Windows 10 build 19045 as Version 22H2.

Description of user facing changes

None

Description of development approach

Tested through Windows Insider Program - added Windows 10 build 19045 metadata.

Testing strategy:

Manual testing: instal Windows 10 build 19045 release preview build to make sure it is recognized as 22H2 by NVDA.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

Additional context:

Split from PR #13867 - Windows 10 22H2 build is certain but not Windows 11 22H2 yet. No need to change SDK requirements as using Windows 11 SDK 10.0.22000 will let NVDA run on Windows 10 22H2 (Vibranium 5).

@josephsl josephsl requested a review from a team as a code owner July 28, 2022 21:32
@josephsl josephsl requested a review from seanbudd July 28, 2022 21:32
@seanbudd seanbudd merged commit 460aec3 into nvaccess:master Jul 29, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Jul 29, 2022
@josephsl josephsl deleted the i13845win10 branch August 16, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows versions: let NVDA recognize Windows 10/11 Version 22H2

3 participants