Skip to content

Review changelog and documentation changes for 2022.3#13933

Merged
seanbudd merged 4 commits into
betafrom
branchBeta2022.3
Jul 26, 2022
Merged

Review changelog and documentation changes for 2022.3#13933
seanbudd merged 4 commits into
betafrom
branchBeta2022.3

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Must be squash merge

Comparison command:
git diff release-2022.2...origin/branchBeta2022.3 -- "**/en/*.t2t" "**/developerGuide.t2t"

Common mistakes to look for:

  • Issue/PR reference is incorrect
  • Incorrect spelling.
  • Lists not terminated with a final - on a new line, matching indentation
  • List items not indented by a multiple of 2 spaces
  • Single grave marks ` instead of double grave marks ``
  • Shortcuts added without code markdown, use two 'grave' characters (NVDA+d)
  • Double spaces
  • Inconsistent use of single vs double quote

@seanbudd seanbudd changed the base branch from master to beta July 21, 2022 01:36
@seanbudd seanbudd changed the base branch from beta to master July 21, 2022 01:36
@seanbudd seanbudd added this to the 2022.3 milestone Jul 21, 2022
@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Jul 21, 2022
@seanbudd seanbudd marked this pull request as ready for review July 21, 2022 01:39
@seanbudd seanbudd requested review from a team as code owners July 21, 2022 01:39
Qchristensen
Qchristensen previously approved these changes Jul 21, 2022
View reviewed changes

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well, good work, and great to highlight our community contributors!

@codeofdusk

codeofdusk commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Wow, looks like NV Access is really picking up the pace with getting releases out the door!

@AppVeyorBot

AppVeyorBot commented Jul 21, 2022

Copy link
Copy Markdown

See test results for failed build of commit 91e2ec74be

codeofdusk
codeofdusk reviewed Jul 21, 2022
View reviewed changes
Comment thread user_docs/en/changes.t2t Outdated
@seanbudd @codeofdusk
address review comment
31208d8 
Co-authored-by: Bill Dengler <codeofdusk@gmail.com>
feerrenrut
feerrenrut previously approved these changes Jul 26, 2022
View reviewed changes
@AppVeyorBot

AppVeyorBot commented Jul 26, 2022

Copy link
Copy Markdown

See test results for failed build of commit 83f9f8272c

@seanbudd seanbudd changed the base branch from master to beta July 26, 2022 05:33
@seanbudd seanbudd dismissed stale reviews from feerrenrut and Qchristensen July 26, 2022 05:33

The base branch was changed.

@seanbudd seanbudd closed this Jul 26, 2022
@seanbudd seanbudd reopened this Jul 26, 2022
@seanbudd seanbudd requested a review from feerrenrut July 26, 2022 05:37
@seanbudd seanbudd merged commit 0a076dc into beta Jul 26, 2022
@seanbudd seanbudd deleted the branchBeta2022.3 branch July 26, 2022 07:32
@XLTechie

XLTechie commented Jul 27, 2022 via email

Copy link
Copy Markdown
Collaborator

@seanbudd

seanbudd commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

@XLTechie - copy paste typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qchristensen Qchristensen Qchristensen left review comments

+2 more reviewers

@codeofdusk codeofdusk codeofdusk left review comments

@feerrenrut feerrenrut feerrenrut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/blocking this issue blocks the milestone release

Projects

None yet

Milestone

2022.3

Development

Successfully merging this pull request may close these issues.

6 participants

@seanbudd @codeofdusk @AppVeyorBot @XLTechie @feerrenrut @Qchristensen