Skip to content

Fixup #13131, ensure speech doesn't interrupt when scrolling braille display#13932

Merged
seanbudd merged 2 commits into
betafrom
fixup-13131
Jul 26, 2022
Merged

Fixup #13131, ensure speech doesn't interrupt when scrolling braille display#13932
seanbudd merged 2 commits into
betafrom
fixup-13131

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 21, 2022

Copy link
Copy Markdown
Member

Link to issue number:

Fixup of #13131

Summary of the issue:

#13131 incorrectly checks the script commands. The initial PR did not use the correct instance of global commands, rather references to the class methods.

Description of user facing changes

#13131 works as intended.

Description of development approach

Testing strategy:

Get a braille user to test the PR build

This patch scrolls the braille viewer display forward every 2 seconds once opened.
Confirmed speech wasn't interrupted.

diff --git a/source/brailleViewer/brailleViewerGui.py b/source/brailleViewer/brailleViewerGui.py
index 33f3ead0a..a8bf947dc 100644
--- a/source/brailleViewer/brailleViewerGui.py
+++ b/source/brailleViewer/brailleViewerGui.py
@@ -451,6 +451,9 @@ class BrailleViewerFrame(
 			self._newCellCount = currentCellCount
 
 		self._triggerGuiUpdate()
+		import core
+		from globalCommands import commands
+		core.callLater(2000, commands.script_braille_scrollForward, "")
 
 	def _triggerGuiUpdate(self):
 		continuousTimerRunning = self._timer.IsRunning() and not self._timer.IsOneShot()

Known issues with pull request:

None

Change log entries:

None - Unreleased feature

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested a review from a team as a code owner July 21, 2022 00:54
@seanbudd seanbudd requested a review from feerrenrut July 21, 2022 00:54
@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Jul 21, 2022
@seanbudd seanbudd added this to the 2022.3 milestone Jul 21, 2022
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit b0e5690a27

@seanbudd seanbudd marked this pull request as draft July 21, 2022 05:12
@burmancomp

Copy link
Copy Markdown
Contributor

Unfortunately display keys do not work anymore.
nvda.log

@seanbudd seanbudd self-assigned this Jul 22, 2022
@seanbudd seanbudd changed the title Fixup #13131, use feature flag option correctly Fixup #13131, ensure speech doesn't interrupt when scrolling braille display Jul 22, 2022
@seanbudd seanbudd marked this pull request as ready for review July 25, 2022 04:43
@seanbudd seanbudd changed the base branch from master to beta July 25, 2022 04:50
@seanbudd seanbudd requested a review from a team as a code owner July 25, 2022 04:50
@seanbudd seanbudd requested review from Qchristensen and removed request for a team July 25, 2022 04:50
@seanbudd seanbudd changed the base branch from beta to master July 25, 2022 04:50
feerrenrut
feerrenrut previously approved these changes Jul 25, 2022
@feerrenrut

Copy link
Copy Markdown
Contributor

After #13946 is merged the base branch will be set to beta, right?

@seanbudd

Copy link
Copy Markdown
Member Author

@burmancomp can you test this build

@seanbudd seanbudd changed the base branch from master to beta July 26, 2022 05:34
@seanbudd seanbudd dismissed feerrenrut’s stale review July 26, 2022 05:34

The base branch was changed.

@seanbudd seanbudd merged commit 4042700 into beta Jul 26, 2022
@seanbudd seanbudd deleted the fixup-13131 branch July 26, 2022 06:19
@burmancomp

Copy link
Copy Markdown
Contributor

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/blocking this issue blocks the milestone release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants