Fixup #13131, ensure speech doesn't interrupt when scrolling braille display#13932
Merged
Conversation
See test results for failed build of commit b0e5690a27 |
Contributor
|
Unfortunately display keys do not work anymore. |
feerrenrut
previously approved these changes
Jul 25, 2022
Contributor
|
After #13946 is merged the base branch will be set to beta, right? |
Member
Author
|
@burmancomp can you test this build |
feerrenrut
approved these changes
Jul 26, 2022
Contributor
|
Works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #13131
Summary of the issue:
#13131 incorrectly checks the script commands. The initial PR did not use the correct instance of global commands, rather references to the class methods.
Description of user facing changes
#13131 works as intended.
Description of development approach
Testing strategy:
Get a braille user to test the PR build
This patch scrolls the braille viewer display forward every 2 seconds once opened.
Confirmed speech wasn't interrupted.
Known issues with pull request:
None
Change log entries:
None - Unreleased feature
Code Review Checklist: