Prevent error if no matching index found after Input Gestures filter#13906
Merged
Conversation
feerrenrut
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13854
Summary of the issue:
When a tree item in the input gestures dialog is selected, then a filter event happens which makes the index no longer valid, an unhandled exception occurs.
This causes multiple Input Gestures to be able to be opened.
STR
Shift+Tabto move to "filter by" edit field and type "z"Description of user facing changes
2 input gesture dialogs can no longer be opened.
Description of development approach
Unselect items when the input gesture filter is updated.
Testing strategy:
Test STR
Known issues with pull request:
None
Change log entries:
Changes
Code Review Checklist: