Skip to content

Prevent error if no matching index found after Input Gestures filter#13906

Merged
seanbudd merged 3 commits into
masterfrom
fixErrorEmptyInputGestures
Jul 18, 2022
Merged

Prevent error if no matching index found after Input Gestures filter#13906
seanbudd merged 3 commits into
masterfrom
fixErrorEmptyInputGestures

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #13854

Summary of the issue:

When a tree item in the input gestures dialog is selected, then a filter event happens which makes the index no longer valid, an unhandled exception occurs.
This causes multiple Input Gestures to be able to be opened.

STR

  1. Open input gestures dialog.
  2. Arrow down to the 4th category (Configuration Profiles)
  3. Press Shift+Tab to move to "filter by" edit field and type "z"
  4. The dialog should refresh with 3 categories
  5. Note an ERROR is logged, as the selected index (4) is larger than the number of categories
  6. Close the Input Gestures dialog (press escape)
  7. Open the Input Gestures dialog
  8. Open a second Input Gestures dialog

Description of user facing changes

2 input gesture dialogs can no longer be opened.

Description of development approach

Unselect items when the input gesture filter is updated.

Testing strategy:

Test STR

Known issues with pull request:

None

Change log entries:

Changes

- Fix bug which allowed 2 Input Gestures dialogs to open. (#13854)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested a review from a team as a code owner July 15, 2022 01:26
@seanbudd seanbudd requested a review from feerrenrut July 15, 2022 01:26
@seanbudd seanbudd changed the title Prevent error if no input gestures found in search Prevent error if no matching index found after Input Gestures filter Jul 15, 2022
@seanbudd seanbudd merged commit 2077431 into master Jul 18, 2022
@seanbudd seanbudd deleted the fixErrorEmptyInputGestures branch July 18, 2022 00:57
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 instances of "Input gestures" dialog open

3 participants